Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download app migration #1

Merged
merged 14 commits into from
Jan 16, 2024
Merged

download app migration #1

merged 14 commits into from
Jan 16, 2024

Conversation

nebfield
Copy link
Member

@nebfield nebfield commented Jan 15, 2024 •
edited
Loading

Changes

  • Splits the old application to use a library/app approach
  • Both library and application are now namespace packages to simplify dependencies and keep everything in the pgscatalog namespace

Backend changes:

  • Moved API calls / downloads requests to httpx because it has better async support (but still using synchronous methods for now)
  • Deleted old retry code, using retry decorator now from tenacity

@nebfield nebfield marked this pull request as draft January 15, 2024 14:03
@nebfield nebfield marked this pull request as ready for review January 16, 2024 11:47
@nebfield nebfield merged commit 41094f7 into main Jan 16, 2024
6 checks passed
@nebfield nebfield deleted the download_app branch January 16, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nebfield