chore: add support for php 8.4

PAYONE-GmbH · Dec 12, 2024 · 8ffb016 · 8ffb016
1 parent f92749d
commit 8ffb016
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 52 deletions.
diff --git a/.github/workflows/lint_and_test.yml b/.github/workflows/lint_and_test.yml
@@ -15,14 +15,17 @@ on:
 jobs:
   lint_test:
     runs-on: ubuntu-20.04
+    strategy:
+      matrix:
+        php: ['8.2', '8.3', '8.4']
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
 
       - name: Set up PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '8.3'
+          php-version: ${{ matrix.php }}
           extensions: composer, xdebug
 
       - name: Get composer cache directory
@@ -33,7 +36,7 @@ jobs:
         uses: actions/cache@v4
         with:
           path: ${{ steps.composer-cache.outputs.dir }}
-          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          key: ${{ runner.os }}-composer-php-${{ matrix.php }}-${{ hashFiles('**/composer.lock') }}
 
       - name: Install dependencies
         run: composer install --no-progress --no-interaction --prefer-dist
@@ -51,9 +54,6 @@ jobs:
         run: composer run-script lint
 
       - name: Test with coverage
-        run: composer run-script coverage
+        run: composer run-script test
+
 
-      - name: SonarCloud Scan
-        uses: SonarSource/sonarcloud-github-action@master
-        env: 
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
diff --git a/.github/workflows/sonar_scanner.yml b/.github/workflows/sonar_scanner.yml
@@ -1,6 +1,13 @@
 name: Run SonarCloud Scan
 
 on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+      - develop
   workflow_call:
   workflow_dispatch:
 
@@ -12,6 +19,29 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
+
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.3'
+          extensions: composer, xdebug
+
+      - name: Get composer cache directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Cache dependencies
+        uses: actions/cache@v4
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} 
+
+      - name: Install dependencies
+        run: composer install --no-progress --no-interaction --prefer-dist
+
+      - name: Test with coverage
+        run: composer run-script coverage
+
       - name: SonarCloud Scan
         uses: SonarSource/sonarcloud-github-action@master
         env: 

diff --git a/.github/workflows/test_backwards.yml b/.github/workflows/test_backwards.yml