[proposal] add perspectives to base theme #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
What kind of change is this?
Please select one of the following five options.
Consult Pull request merging criteria for a description of each category.
Major change release plan
TODO: For any non-MAJOR change, delete this whole section.
For a MAJOR change as defined in Schema versioning and stability,
indicate the expected release date, related minor change steps, and your
public documentation and messaging plan.
A. Expected release date for this MAJOR change
TODO.
B. Related MINOR change steps
C. Public documentation and messaging lan
TODO.
Description
Perspectives for Geographic Features
We are all familiar with disputes and perspectives as a function of dealing with administrative names and borders. There also exist complex perspectives over geographic features. Common examples that our users may need to support are the Sea of Japan and the Falkland Islands.
This PR proposes the following changes:
is_disputed
to the base theme to flag features like mountain points, polygonal water bodies, polygonal land bodies, etc. that may contain disputed nameperspectives
to the base theme, when used in conjunction withis_disputed
this allows users to create the proper perspective view.disputed
as a valid value to the rules for names. Disputed names may be a separate thing from the common or official names.TODO.
Reference
List of relevant links to GitHub issues, PRs, and other documentation.
Testing
Brief description of the testing done for this change showing why you are confident it works as expected and does not introduce regressions. Provide sample output data where appropriate.
TODO.
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
A
but is not intended to test propertyA
's validity, and you made a schema change that invalidates propertyA
in that counterexample, fix the counterexample to align it with your schema change.Documentation Website
Update the hyperlink below to put the pull request number in.
[Docs preview for this PR.](https://dfhx9f55j8eg5.cloudfront.net/pr/<PUT THE PR # HERE>)