Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSS height of MapLibre element to show attribution [#41] #52

Merged
merged 1 commit into from
May 26, 2024
Merged

Fix CSS height of MapLibre element to show attribution [#41] #52

merged 1 commit into from
May 26, 2024

Conversation

bdon
Copy link
Contributor

@bdon bdon commented May 25, 2024

Shortens the map by 60px (the navbar height)

Screenshot 2024-05-25 at 16 10 52

@charliemcgrady charliemcgrady merged commit 6b004bd into OvertureMaps:main May 26, 2024
1 check passed
@bdon
Copy link
Contributor Author

bdon commented May 28, 2024

There's also a Footer element that is still hidden by the map; do we want to keep that in the Map view, or is it meant to be shown on non-map pages?

Screenshot 2024-05-28 at 17 13 21

(The site as-is has a CSS height > 100vh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdon @charliemcgrady