Add bathymetry outline layer to base theme. #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliemcgrady
commented
Dec 20, 2024
| { | ||
| theme: "base", | ||
| type: "bathymetry", | ||
| outline: true, |
There was a problem hiding this comment.
The bathymetry layer is exclusively polygons. I chose an outline over a fill layer because the inner area of the bathymetry polygons overlap with land, leading to irrelevant clicks. Outline layers better represent boundaries.
charliemcgrady
commented
Dec 20, 2024
| @@ -141,6 +141,22 @@ const ThemeTypeLayer = ({ | |||
| {...(minzoom ? { minzoom } : {})} | |||
| /> | |||
| ) : null} | |||
| {outline ? ( | |||
| <Layer | |||
There was a problem hiding this comment.
Add an invisible line which is larger than the rendered outline to enable easier clicks.
Bonkles
approved these changes
Dec 23, 2024
jonahadkins
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bathymetry to the Overture Explorer.
https://explore.overturemaps.org/aria/c5ab0ff-20.x-aria.html#3.31/38.7/-42.62