Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled download button below a certain zoom threshold #37

Closed
Bonkles opened this issue May 19, 2024 · 0 comments · Fixed by #63
Closed

Disabled download button below a certain zoom threshold #37

Bonkles opened this issue May 19, 2024 · 0 comments · Fixed by #63
Assignees
@eti7075

Comments

@Bonkles
Copy link
Collaborator

Bonkles commented May 19, 2024 •
edited
Loading

Let's disable the download button until we achieve a certain minimum zoom threshold. Say, zoom 16?

We should also use react-floater (the core component that supports react-joyride) to put a tooltip on the download button that indicates why it's been disabled, and that zooming in will enable it.
@Bonkles Bonkles changed the title Reactive zoom behavior Disabled download button below a certain zoom threshold Jun 4, 2024
@eti7075 eti7075 self-assigned this Jun 4, 2024
@eti7075 eti7075 linked a pull request Jun 5, 2024 that will close this issue
Disable download button and show tooltip at low zoom levels. [#37 #59] #63
Merged
Bonkles pushed a commit that referenced this issue Jun 7, 2024
@eti7075
Disable download button and show tooltip at low zoom levels. [#37 #59] (
e057b29 
#63)

* Added zoom state to disable downloads at low zooms

* added a simple floater when hovering over disabled button

* Added proper tooltip message and simple styling

* Download button is properly dis/enabled when page refreshes

* Added overturemaps-py shoutout

* Show tooltip on diabled button click

---------

Co-authored-by: ethaniannicelli <eti7075@rit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eti7075 eti7075

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable download button and show tooltip at low zoom levels. [#37 #59] OvertureMaps/io-site
2 participants
@Bonkles @eti7075