Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prop type cleanup #141

Open
Bonkles opened this issue Aug 7, 2024 · 0 comments
Open

Prop type cleanup #141

Bonkles opened this issue Aug 7, 2024 · 0 comments
Labels
chore good first issue Good for newcomers

Comments

@Bonkles
Copy link
Collaborator

Bonkles commented Aug 7, 2024

Description

When enabling/disabling the themes in the theme selector, pinning various things, in development mode console there are many errors pertaining to properties missing from props validation.

In Map.jsx, you can see that there is an example block with a single property type defined:

Map.propTypes = {
  mode: PropTypes.string.isRequired,
};

But open nearly any other .jsx file in the repo and they're missing these type declarations. We should clean all these up!

What browser are you seeing the problem on? What version are you running?

all

The OS you're using

any

Steps to reproduce

Pop open any .jsx file in the site using VSCode, and you will see many errors.

image

GERS ID of the entity in question (if applicable)

n/a

The browser URL at the time you encountered the bug

n/a

@Bonkles Bonkles added good first issue Good for newcomers chore labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant