Java 8 Compatibility #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, that might be a problem. Hmmm. |
|
Okay, it works now, I think |
wagyourtail
reviewed
Sep 9, 2024
| @@ -220,16 +225,29 @@ public static void compileMmcZip(Path outPutDir, String gameVersion, LoaderType | |||
| Path zipFile = outPutDir.resolve("Ornithe-" + gameVersion + ".zip"); | |||
| Files.deleteIfExists(zipFile); | |||
|
|
|||
| try (FileSystem fs = FileSystems.newFileSystem(zipFile, Map.of("create", "true"))) { | |||
| // This is a god awful workaround, because paths can't be cleanly converted to URIs in j8, and for some reason, you can't pass parameters into newFileSystem with a path argument. | |||
There was a problem hiding this comment.
they can be converted, it's just
URI.create("jar:" + path.toUri())There was a problem hiding this comment.
That doesn't work on windows, cause:
- Windows uses
\, which is an illegal char. - Windows also has the drive name, which itself is illegal to have in a URI.
- I can't replace
\with/and then urlencode it, because it then encodes/, which then breaks the path. - I can't just manually escape space and colon (the two main offenders of breaking path), cause the path component is still somehow undefined.
I love J8 path API on windows :)
There was a problem hiding this comment.
actually, path.toUri on windows looks like file:///C:/path/to/file on windows. and is a valid uri
and adding jar: on the front makes FileSystems recognize it as a zip properly on java 8 as the scheme becomes jar:file:
There was a problem hiding this comment.
This still ends up at the exact same "path component is undefined" error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, massive disclaimer: I did this in like 30 minutes flat, and I took a bunch of shortcuts (static initializer spam go brrrr), so be aware that the code probably isn't as clean as it should be.
A few major(ish) notes to take into account:
MmcPackCreator.class)tasks.compileJava.source/targetCompatiblityfor all versions of java, also sets the IDE java compat for you as well, which is nice.)I have tested the mmc pack and server and can confirm they're fully working.
I'm able to install the vanilla launcher one, but the crappy minecraft launcher doesn't work for me, so I can't test it.
If explanations are needed for anything I did, feel free to ask.