Upstream Sync for Minecraft 1.13 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Norwegian Bokmål translations
- Updated Chinese translations
- Updated Belarusian translations
- Change Twitter name to X (Twitter)
- Delay loading API implementations until it's first needed in attempt to fix Architectury API's usage (beta)
* Add support for custom update checking logic * Rename ModrinthUtil to UpdateCheckerUtil * Make download link required * Fix search * Use a separate thread for every custom update checker --------- Co-authored-by: Max Henkel <max@maxhenkel.de>
- Fixed disable_update_checker config option not working
…r (#704) * Allow choosing an update channel to receive notifications for * Pass user preferred update channel to UpdateChecker * Change method of getting the preferred update channel * Request preferred version types from Modrinth only * Switch update channel and quick configure button order * Rerun update checks when clicking done in the modmenu options screen - No longer promotes updates to beta or alpha versions by default
* Display credits by role instead of bunching them together * Add newlines between credit groups, allow translating role names * Fix minor code style issues * Improve translation key generation and fallback role names * Sort contributors within roles * Fix Fabric authors being credited wrong - Group mod credits together by role
- Fix Mod Menu build metadata not being properly stripped from the User Agent string generation for privacy
- Add update checkers for Fabric Loader and Quilt Loader - Add API for mods to provide update checkers for other mods
…her than the button - Fix update checker not being run when config screen is closed without the Done button
This was referenced Apr 23, 2024
|
This should not be merged yet since there is an issue that needs to be fixed upstream (or in Modrinth?) and then added here. |
- Fixed contributors being sorted
- Update Chinese Translation
- Updated Tatar Translation
- Updated Polish Translation
- Updated Belarusian Translation
Fixes #693 - Fixed crash with unknown badges
…(#716) - Fixed update checker promoting downgrades
|
Upstream got some bug fixes merged, meaning the issues with this are now resolved. I will update the other PRs I made for the other branches tomorrow. |
|
And now that's done! |
SpaceWalkerRS
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features cherry-picked from upstream ModMenu.
Resolves #4.
Resolves #5.