Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when search yields no results #22

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

LostLuma
Copy link
Contributor

Resolves #20 for Minecraft 1.7 and above.
This is the same as #21 except applied in the least invasive way to the vanilla class that was used here.

@SpaceWalkerRS
Copy link
Member

I'm not too fond of including a beta version of Mixin Extras in the mod. I'd like to wait for it to enter a new release and merge this once Loader updates to it. Then again it doesn't strike me as a very obscure crash so perhaps a more invasive fix in the meantime is the way to go.

@LostLuma
Copy link
Contributor Author

Alright, I was kinda wondering whether it'd be a bad idea :) I shall change it to make the value of n be 0 instead.

Signed-off-by: Lilly Rose Berner <lilly@lostluma.net>
@LostLuma LostLuma force-pushed the fix/search-crash-modern branch from 35edff5 to a739fef Compare February 21, 2025 08:35
Signed-off-by: Lilly Rose Berner <lilly@lostluma.net>
@SpaceWalkerRS SpaceWalkerRS merged commit 18a2eeb into OrnitheMC:1.12 Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants