Package upgrades #72
Merged
Package upgrades #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 12, 2023 12:35
|
KubernetesClient shouldn't be private as your package needs it to work right? |
|
KubernetesClient shouldn't be private as your package needs it to work right? @vader1986 @galvesribeiro |
|
Yes, sorry my mistake |
| @@ -27,7 +27,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="KubernetesClient" Version="10.0.31" PrivateAssets="All" /> | |||
| <PackageReference Include="KubernetesClient" Version="10.0.31" /> | |||
There was a problem hiding this comment.
I think we should upgrade this as well. Not sure if there are too many breaking changes...
There was a problem hiding this comment.
There was this PR, that's why I didn't upgrade:
#69
But makes sense to me. Will include that upgrade here.
|
LGTM? |
galvesribeiro
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.