Fix validateUpgradeSafety to handle undefined ast #1127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OpenZeppelin#1126 Handle undefined `ast` in `validateUpgradeSafety`. * Add a check in `checkNamespacesOutsideContract` to verify if `solcOutput.sources[source].ast` is undefined before accessing its `nodes` property. * Log a warning and skip the check if `solcOutput.sources[source].ast` is undefined. * Add a test case in `validate-upgrade-safety.test.ts` to verify the behavior when `solcOutput.sources[source].ast` is undefined. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/OpenZeppelin/openzeppelin-upgrades/issues/1126?shareId=XXXX-XXXX-XXXX-XXXX).
|
Thanks for this PR. From the original issue, it looks like We'll investigate the original issue further, but this doesn't look like the right approach. The AST is required for validations so missing AST should not be suppressed with a warning. The checks in I'll close this PR but feel free to continue the discussion in the original issue or here if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1126
Handle undefined
astinvalidateUpgradeSafety.checkNamespacesOutsideContractto verify ifsolcOutput.sources[source].astis undefined before accessing itsnodesproperty.solcOutput.sources[source].astis undefined.validate-upgrade-safety.test.tsto verify the behavior whensolcOutput.sources[source].astis undefined.For more details, open the Copilot Workspace session.