Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update validation-tests.yml pipenv install issues #1080

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

Mionsz
Copy link
Collaborator

@Mionsz Mionsz commented Feb 11, 2025

Fix: Update validation-tests.yml pipenv install issues

@Mionsz Mionsz marked this pull request as ready for review February 11, 2025 14:44
@Mionsz Mionsz force-pushed the validation-automation-install-pipenv branch 15 times, most recently from c07c278 to 5855a2b Compare February 12, 2025 07:09
@zLukas
Copy link
Collaborator

zLukas commented Feb 12, 2025

In my opionion, we should be able to run it loccally then use GHA as executor. This approach have two main benefits:

  • you are independent from GHA (f.e. when gh is temporary down) , you can run it anywhere, and it's more flexible.
  • fixing workflow is easier locally rather than in gha yaml file, as you have more debugging, local testing options and more people might have a chance to fix if they do not feel confortable with GHA.

so my suggextion is to keep inputs, and triggers as it is, but encapsule/merge (to some extent) run steps to scripts that are kept in repo.

@Mionsz Mionsz force-pushed the validation-automation-install-pipenv branch 7 times, most recently from b02473d to e623f83 Compare February 18, 2025 10:54
@Mionsz Mionsz force-pushed the validation-automation-install-pipenv branch 2 times, most recently from 630f774 to 47fc829 Compare February 18, 2025 12:47
Fix: Update validation-tests.yml pipenv  install issues and run issues
Add: Multiple test cases run inputs
Add: Dropdown for pre-release use cases
Add: Fixtures.py time.sleep between runs
Signed-off-by: Milosz Linkiewicz <milosz.linkiewicz@intel.com>
Fix: Fixed overall pytest/workflow run success rate by using single cases and retry approach
Feature: Working inputs.validation-tests-2 input
Feature: Type of bonding to use for validation run (Validation-iface-binding)
Feature: Type of port_p and port_r to use for validation run (validation-test-port-p, validation-test-port-r)

Signed-off-by: Milosz Linkiewicz <milosz.linkiewicz@intel.com>
Fixed: Set an timeout to 12h as tests can be lengthy
Refactor: Moved validation tests run to script file

Signed-off-by: Milosz Linkiewicz <milosz.linkiewicz@intel.com>
@Mionsz Mionsz force-pushed the validation-automation-install-pipenv branch from 47fc829 to f3c0faf Compare February 18, 2025 13:05
@Mionsz Mionsz enabled auto-merge (squash) February 18, 2025 13:07
@Mionsz Mionsz merged commit 0b6d41c into main Feb 18, 2025
31 checks passed
@Mionsz Mionsz deleted the validation-automation-install-pipenv branch February 18, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants