-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update validation-tests.yml pipenv install issues #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c07c278
to
5855a2b
Compare
zLukas
requested changes
Feb 12, 2025
In my opionion, we should be able to run it loccally then use GHA as executor. This approach have two main benefits:
so my suggextion is to keep inputs, and triggers as it is, but encapsule/merge (to some extent) |
zLukas
requested changes
Feb 12, 2025
b02473d
to
e623f83
Compare
630f774
to
47fc829
Compare
Fix: Update validation-tests.yml pipenv install issues and run issues Add: Multiple test cases run inputs Add: Dropdown for pre-release use cases Add: Fixtures.py time.sleep between runs Signed-off-by: Milosz Linkiewicz <milosz.linkiewicz@intel.com>
Fix: Fixed overall pytest/workflow run success rate by using single cases and retry approach Feature: Working inputs.validation-tests-2 input Feature: Type of bonding to use for validation run (Validation-iface-binding) Feature: Type of port_p and port_r to use for validation run (validation-test-port-p, validation-test-port-r) Signed-off-by: Milosz Linkiewicz <milosz.linkiewicz@intel.com>
Fixed: Set an timeout to 12h as tests can be lengthy Refactor: Moved validation tests run to script file Signed-off-by: Milosz Linkiewicz <milosz.linkiewicz@intel.com>
47fc829
to
f3c0faf
Compare
zLukas
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Update validation-tests.yml pipenv install issues