Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clicksound support to Buttons #382

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Add clicksound support to Buttons #382

merged 1 commit into from
Feb 10, 2025

Conversation

Spartan322
Copy link
Member

@Spartan322 Spartan322 commented Feb 10, 2025 •
edited
Loading

Fix StyleBoxWithSound draw bug
Expose SoundSingleton audio stream load functions
Update OpenVicProject/OpenVic-Simulation@34d3227

@Spartan322 Spartan322 added the enhancement New feature or request label Feb 10, 2025
@Spartan322 Spartan322 force-pushed the add/clicksound-support branch from dd7e9e7 to 8ad33be Compare February 10, 2025 21:33
Hop311
Hop311 previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Hop311 Hop311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, particularly interesting to see you connecting a Godot signal to a C++ lambda function, I don't think I knew that could be done. All the sounds are working for me, just a few minor comments

extension/src/openvic-extension/classes/resources/StyleBoxWithSound.hpp Outdated Show resolved Hide resolved
extension/src/openvic-extension/utility/UITools.cpp Outdated Show resolved Hide resolved
extension/src/openvic-extension/utility/UITools.cpp Outdated Show resolved Hide resolved
extension/src/openvic-extension/singletons/SoundSingleton.cpp Outdated Show resolved Hide resolved
extension/src/openvic-extension/utility/UITools.cpp Outdated Show resolved Hide resolved
@Spartan322 Spartan322 force-pushed the add/clicksound-support branch 3 times, most recently from 91ae86f to b5f9580 Compare February 10, 2025 22:50
@Spartan322
Add clicksound support to Buttons
6b062e2 
Fix StyleBoxWithSound draw bug
Expose SoundSingleton audio stream load functions
Update OpenVicProject/OpenVic-Simulation@34d3227
@Spartan322 Spartan322 force-pushed the add/clicksound-support branch from b5f9580 to 6b062e2 Compare February 10, 2025 22:57
@Hop311 Hop311 merged commit 1fc952c into OpenVicProject:master Feb 10, 2025
10 checks passed
@Spartan322 Spartan322 deleted the add/clicksound-support branch February 11, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hop311 Hop311 Hop311 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Spartan322 @Hop311