Add MapView to LobbyMenu #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hop311
previously approved these changes
Feb 2, 2025
Replace MapView province hover behavior with signal Replace MapView province unhover behavior with signal Replace MapView province click behavior with signal Replace MapView province right click behavior with signal Add MapView province behavior signal implementations to GameSession Add LobbyMenu MapView TODOs Change GameSession scene type to Node
Spartan322
force-pushed
the
add/basic-lobby-map-view
branch
from
322e19d to
410615b
Compare
Hop311
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace MapView province hover behavior with signal
Replace MapView province unhover behavior with signal
Replace MapView province click behavior with signal
Replace MapView province right click behavior with signal
Add MapView province behavior signal implementations to GameSession
Add LobbyMenu MapView TODOs
Change GameSession scene type to Node