Add pre-commit configuration file #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartan322
force-pushed
the
add/pre-commit
branch
3 times, most recently
from
d742bb3 to
c70cf0a
Compare
Spartan322
force-pushed
the
add/pre-commit
branch
from
c70cf0a to
34cdb6f
Compare
wvpm
reviewed
Jan 22, 2025
Spartan322
force-pushed
the
add/pre-commit
branch
from
34cdb6f to
088c4e9
Compare
wvpm
previously approved these changes
Jan 22, 2025
Spartan322
force-pushed
the
add/pre-commit
branch
2 times, most recently
from
b5b7caa to
5c5176a
Compare
wvpm
previously approved these changes
Jan 22, 2025
Spartan322
force-pushed
the
add/pre-commit
branch
from
5c5176a to
affd811
Compare
wvpm
previously approved these changes
Jan 22, 2025
Spartan322
force-pushed
the
add/pre-commit
branch
2 times, most recently
from
7b000d1 to
85edeb7
Compare
Hop311
reviewed
Jan 22, 2025
There was a problem hiding this comment.
A few primitives in GUIListBox have had their constructor initialisation removed with no replacement in the header.
Also if we need to move initialisation into the header/declaration, it would be better to do so completely rather than leaving a mix between the two which makes it difficult to tell what is and isn't initialised.
Spartan322
force-pushed
the
add/pre-commit
branch
from
85edeb7 to
e4e0c96
Compare
Hop311
previously approved these changes
Jan 22, 2025
Add typos checks and corrections Add static check github action Add clang-tidy corrections Use optional initialization for PROPERTY macros
Spartan322
force-pushed
the
add/pre-commit
branch
from
e4e0c96 to
c3d8a04
Compare
Hop311
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add typos checks and corrections
Add static check github action
Add clang-tidy corrections
Use optional initialization for PROPERTY macros
Implements everything but clang-format from #305
When this is merged, the
victoria 2 discrepencyneeds to immediately be renamed tovictoria 2 discrepancy