TimeEffect to LinearTimeWarp Conversion Fixes #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as well as extends the transcribe_linear_time_warp function to better handle reverse time effects.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a test aaf and further testing for the time effects -> linear time warp conversion. Most of these changes were pulled from Josh Minor's forked adapter. The added test is incomplete, as the test aaf contains more clips that need tests written for them. It does, however test that the trim to fill, fit to fill, and backwards time effects are properly converted to linear time warps.
This includes and slightly extends #54
From that pull request:
"This PR attempts to fix the AAF->OTIO conversion of trim-to-fill time warp effects. Previously, they were translated as generic TimeEffects without any information (just a dump of AAF metadata). Now they are detected as LinearTimeWarp effects and a time_scalar is computed from keyframes and/or SpeedRatio.
Note, this PR is a draft. Further unit tests need to be added to verify correct behavior.
Also note that I did this work on top of @markreidvfx 's #44 but I believe this PR could be separated from that one, since the change is unrelated."