Add volume up / down reset on usb report complete (this should be a b…

…uilt-in in input drivers). Also fixed a silly web config thing
OpenStickCommunity · Jan 24, 2025 · d4056be · d4056be
1 parent 37027f7
commit d4056be
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/drivers/keyboard/KeyboardDriver.cpp b/src/drivers/keyboard/KeyboardDriver.cpp
@@ -95,10 +95,8 @@ void KeyboardDriver::process(Gamepad * gamepad) {
 
     if( volumeChange > 0 ) {
         pressKey(KEYBOARD_MULTIMEDIA_VOLUME_UP);
-        volumeChange--;
     } else if ( volumeChange < 0 ) {
         pressKey(KEYBOARD_MULTIMEDIA_VOLUME_DOWN);
-        volumeChange++;
     }
 
 	// Wake up TinyUSB device
@@ -123,6 +121,13 @@ void KeyboardDriver::process(Gamepad * gamepad) {
 			if ( tud_hid_report(keyboardReport.reportId, keyboard_report_payload, keyboard_report_size) ) {
 				memcpy(last_report, keyboard_report_payload, keyboard_report_size);
 				last_report_size = keyboard_report_size;
+
+                // Adjust volume on success
+                if( volumeChange > 0 ) {
+                    volumeChange--;
+                } else if ( volumeChange < 0 ) {
+                    volumeChange++;
+                }
 			}
 		}
 	}

diff --git a/www/src/Addons/Rotary.tsx b/www/src/Addons/Rotary.tsx
@@ -44,7 +44,7 @@ export const rotaryScheme = {
 		.number()
 		.required()
 		.label('Rotary Encoder Add-On Enabled'),
-	encoderOneEnabled: yup.number().required().label('Encoder One Enabled'),
+	encoderOneEnabled: yup.boolean().required().label('Encoder One Enabled'),
 	encoderOnePinA: yup
 		.number()
 		.label('Encoder One Pin A')
@@ -66,7 +66,7 @@ export const rotaryScheme = {
 		.required()
 		.label('Encoder One Allow Wrap Around'),
 	encoderOneMultiplier: yup.number().label('Encoder One Multiplier').required(),
-	encoderTwoEnabled: yup.number().required().label('Encoder Two Enabled'),
+	encoderTwoEnabled: yup.boolean().required().label('Encoder Two Enabled'),
 	encoderTwoPinA: yup
 		.number()
 		.label('Encoder Two Pin A')