Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced interp1d with InterpND in tests and docs #1125

Merged
merged 61 commits into from
Nov 18, 2024
Merged

Replaced interp1d with InterpND in tests and docs #1125

merged 61 commits into from
Nov 18, 2024

Conversation

swryan
Copy link
Contributor

@swryan swryan commented Nov 4, 2024 •
edited
Loading

Summary

This PR replaces the use of SciPy's interp1d in tests and docs with with OpenMDAO's InterpND since SciPy is dropping support for interp1d:

Legacy

This class is considered legacy and will no longer receive updates. This could also mean it will be removed in future SciPy versions. For a guide to the intended replacements for interp1d see 1-D interpolation.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@swryan swryan requested a review from robfalck November 4, 2024 15:01
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@coveralls
Copy link

coveralls commented Nov 4, 2024 •
edited
Loading

Coverage Status

coverage: 93.67% (-0.2%) from 93.877%
when pulling 7c1372c on swryan:interp
into f05f58c on OpenMDAO:master.

swryan and others added 25 commits November 4, 2024 13:39
@swryan
use scipy interpolate methods in Phase and assert_timeseries
031cf79
@swryan
fix load_case tests
0d6904b
@swryan
interxd
7babe00
@swryan
docstrings
e1e21ee
@swryan
linear
6423168
@robfalck
Added ability to retrieve interpolated values in phase on an arbitrar…
a3dc1da 
…y set of nodes.
@robfalck
Use make_interp_spline for backward compatibility
df0ef9f
@swryan
interp_update
b3e2726
@swryan
pep
60b803a
@swryan
Merge branch 'interp_update' into interp
4a70fc0
@swryan
pep
2faa37c
@swryan
conda-remove-defaults
dee2098
@swryan
conda-remove-defaults
943ec14
@swryan
conda-remove-defaults
5bd8649
@robfalck
Fixed sorting issue when using np.unique to remove duplicate time val…
a4adabe 
…ues in interpolation.
@robfalck
Debugging mpi tests on github latest matrix
fc8c849
@robfalck
mpi testing
24d6c82
@robfalck
mpi testing
cadde2d
@robfalck
mpi testing
7de678d
@robfalck
mpi testing
dab251c
@robfalck
mpi testing
f5f159c
@robfalck
mpi testing
bf0e124
@robfalck
mpi testing. reduced tolerance for restart checks with new interpolat…
d10a944 
…ion.
@robfalck
mpi testing
6ebe1f0
@robfalck
mpi testing
6819b44
robfalck and others added 27 commits November 11, 2024 09:44
@robfalck
more tweaking of implicit duration doc
c52cc88
@robfalck
Merge branch 'master' into interp_update
a046241
@robfalck
more doc work
8b3194b
@robfalck
still working on the single failing test in the latest matrix. remove…
ffbb0de 
…d interpolate function from phase.
@robfalck
restore tests
235367c
@robfalck
removed old upgrade guide
35f0d36
@robfalck
attempt to fix water rocket on latest
cfea6eb
@robfalck
more debugging of water rocket cases.
c2b6ed2
@robfalck
water rocket problem convergence issues
b04cb16
@robfalck
balancing lagrange multipliers
bd75be5
@robfalck
water rocket for docs failing latest.
27cca3a
@robfalck
removed birkhoff from racecar test due to slowness
96e0c66
@robfalck
skipping two burn orbit raise MPI to debug if that is the issue on la…
0b354d5 
…test.
@robfalck
test cleanup
8a217f5
@robfalck
pad interpolation table for cannonball with implicit duration.
4085266
@robfalck
more cleanup
3153fe4
@robfalck
Allow extrapolation in cannonball implicit duration test.
1671964
@robfalck
trying to change interpolant to make_interp_spline
4fc87b7
@robfalck
testing bounds enforcing linesearch
773f7cc
@robfalck
testing implicit duration with SLSQP
43b6a9c
@robfalck
another try.
52c5018
@robfalck
punt
7783cf3
@robfalck
adding two burn orbit raise mpi example back in with radau transcript…
e4e4e1e 
…ion instead of gl
@robfalck
cleanup
2bc3395
@swryan
Merge branch 'interp_update' into interpXD
82378b1
@swryan
merge
37a30dc
@swryan
Merge branch 'master' into interp
7c1372c
@swryan swryan marked this pull request as ready for review November 18, 2024 15:12
@robfalck robfalck merged commit 42fea76 into OpenMDAO:master Nov 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robfalck robfalck robfalck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swryan @coveralls @robfalck