Fix for failing multi-engine tests. #618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiengine test a bit.
crecine
reviewed
Dec 4, 2024
Comment on lines
+410
to
+413
| try: | ||
| aviary_options.get_val(var) | ||
| except KeyError: | ||
| aviary_options.set_val(var, np.zeros(num_engine_type)) |
There was a problem hiding this comment.
I think this might be more clear?
Suggested change
| try: | |
| aviary_options.get_val(var) | |
| except KeyError: | |
| aviary_options.set_val(var, np.zeros(num_engine_type)) | |
| if key not in aviary_options: | |
| aviary_options.set_val(var, np.zeros(num_engine_type)) |
|
Hotfixed by #622 for now. New solution will involve working with the defaults so that they are broadcast out to the correct size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary of PR.
Related Issues
Backwards incompatibilities
None
New Dependencies
None