Fix a bug with timeout error handling #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates how the server handles SSL/TLS timeout errors when reading incoming client requests. Timeouts are now interpreted as session ending events, resulting in a closed connection as opposed to the original recurring error log message that was produced.
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 95.07% 95.06% -0.02%
==========================================
Files 75 75
Lines 12671 12674 +3
==========================================
+ Hits 12047 12048 +1
- Misses 624 626 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates how the server handles SSL/TLS timeout errors when reading incoming client requests. Timeouts are now interpreted as session ending events, resulting in a closed connection as opposed to the original recurring error log message that was produced.