Use pydantic > 1
#192
Use pydantic > 1
#192
Conversation
Try un-pinning `pydantic` and allowing it to be pinned by other packages as needed.
Getting weird solves; trying to address this.
|
Looks like we may be getting blocked by I've raised an issue on the |
|
Otherwise, all tests passing when I run locally. 😁 |
|
Getting weird hangs on the test suite in CI, but I can't reproduce the hangs locally. 🥲 |
dotsdl
added this to the Release 0.6.0 - "living networks" and automated strategies enablement milestone
|
If you want to test against upcoming versions of the OpenFF stack with natively pydantic 2 objects, you can grab the OpenFF stack from the |
|
We can switch wholly to |
Needed to use "before" validation in many cases, since we either want to validate inputs before model is instantiated or we want to modify those inputs before model is instantiated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 80.34% 80.38% +0.04%
==========================================
Files 26 26
Lines 3698 3711 +13
==========================================
+ Hits 2971 2983 +12
- Misses 727 728 +1 ☔ View full report in Codecov by Sentry. |
|
Looks like we got |
|
Can I get a review from you @ianmkenney? In particular, can you check that from your perspective we're using proper |
Try un-pinning
pydanticand allowing it to be pinned by other packages as needed.