Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi line generic conversions in Python #1918

Merged
merged 2 commits into from
Feb 23, 2025

Conversation

ryanmelt
Copy link
Member

No description provided.

@ryanmelt ryanmelt requested a review from jmthomas February 23, 2025 02:35
@ryanmelt ryanmelt changed the title Fix multi line generic conversions Fix multi line generic conversions in Python Feb 23, 2025
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.60%. Comparing base (b0aaee5) to head (d5eca55).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1918   +/-   ##
=======================================
  Coverage   79.60%   79.60%           
=======================================
  Files         525      525           
  Lines       41158    41164    +6     
=======================================
+ Hits        32762    32770    +8     
+ Misses       8396     8394    -2     
Flag Coverage Δ
python 84.22% <ø> (+<0.01%) ⬆️
ruby-api 48.51% <ø> (ø)
ruby-backend 82.68% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize multiline python generic conversions was broken. Nice.

@ryanmelt ryanmelt merged commit f63717b into main Feb 23, 2025
30 checks passed
@ryanmelt ryanmelt deleted the python_multi_line_generic_conversion branch February 23, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants