Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception catch on python hostname lookup #1915

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

ryanmelt
Copy link
Member

closes #1911

@ryanmelt ryanmelt requested a review from jmthomas February 22, 2025 17:51
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.95%. Comparing base (482621e) to head (3ba61a1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1915      +/-   ##
==========================================
- Coverage   79.61%   77.95%   -1.67%     
==========================================
  Files         525      525              
  Lines       41155    41158       +3     
==========================================
- Hits        32767    32086     -681     
- Misses       8388     9072     +684     
Flag Coverage Δ
python 84.15% <ø> (-0.08%) ⬇️
ruby-api 48.51% <ø> (ø)
ruby-backend 79.65% <ø> (-3.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like hostname is only used in the InterfaceInfo so it's fine to just put "UNKNOWN" if it fails.

@ryanmelt ryanmelt merged commit 2adda68 into main Feb 22, 2025
28 of 30 checks passed
@ryanmelt ryanmelt deleted the catch_hostname_lookup_errors branch February 22, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hostname Resolution Error for TcpipServerInterface.py
2 participants