Update dependencies #1910
Update dependencies #1910
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1910 +/- ##
==========================================
- Coverage 79.61% 79.57% -0.04%
==========================================
Files 525 525
Lines 41155 41155
==========================================
- Hits 32767 32751 -16
- Misses 8388 8404 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmthomas
force-pushed
the
dependencies
branch
from
ace815e to
0645df0
Compare
|
| .inputValue() | ||
| await page | ||
| .locator('[data-test=file-open-save-filename] input') | ||
| .fill(`${prepend}/save_new.rb`) |
There was a problem hiding this comment.
This section of playwright was failing so I took a similar example from the file-menu.spec.ts
| @@ -213,7 +213,7 @@ def shutdown | |||
| @cancel_thread = true | |||
| @microservice_status_sleeper.cancel if @microservice_status_sleeper | |||
| MicroserviceStatusModel.set(as_json(:allow_nan => true), scope: @scope) | |||
| FileUtils.remove_entry(@temp_dir) if File.exist?(@temp_dir) | |||
| FileUtils.remove_entry_secure(@temp_dir, true) | |||
There was a problem hiding this comment.
See https://docs.ruby-lang.org/en/3.2/FileUtils.html#method-c-remove_entry_secure. I think we were running into the TOCTTOU Vulnerability (https://docs.ruby-lang.org/en/3.2/FileUtils.html#module-FileUtils-label-Avoiding+the+TOCTTOU+Vulnerability) because we're explicitly using the /tmp directory everywhere.
| return !!value || 'Required' | ||
| } | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Actual bug when handling multiple files in the FileDialog
| puts "ERROR: While updating #{package} to #{latest} got the following:\n#{data}\n\nCheck the package and version." | ||
| FileUtils.rm outfile | ||
| exit 1 | ||
| end |
There was a problem hiding this comment.
I added this so this script doesn't just plow ahead when it gets a 404 error from curl and returns an error string instead of the file.
No description provided.