First pass audit of the playwright tests #1871
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1871 +/- ##
=======================================
Coverage 79.46% 79.46%
=======================================
Files 523 523
Lines 40918 40926 +8
=======================================
+ Hits 32514 32522 +8
Misses 8404 8404
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| await utils.sleep(100) | ||
| await page.locator('[data-test=file-open-save-search]').type('nect') | ||
| await page.locator('[data-test=file-open-save-search] input').fill('nect') | ||
| await utils.sleep(100) |
There was a problem hiding this comment.
The idea here was to type it like the user would which is what the incremental type with delay is. But I see in the script-runner/api.spec that you just removed it all and did a simple fill. If that works here great.
| await utils.sleep(100) | ||
| await page.locator('[data-test=file-open-save-search]').type('data') | ||
| await page.locator('[data-test=file-open-save-search] input').fill('data') | ||
| await utils.sleep(100) |
There was a problem hiding this comment.
Same here with the typing and sleep.
| @@ -161,12 +166,12 @@ test('loads Suite controls when opening a suite', async ({ page, utils }) => { | |||
| await page.locator('[data-test=script-runner-file]').click() | |||
| await page.locator('text=Open File').click() | |||
| await utils.sleep(1000) | |||
| await page.locator('[data-test=file-open-save-search]').type('dis') | |||
| await page.locator('[data-test=file-open-save-search] input').fill('dis') | |||
There was a problem hiding this comment.
It is according to my LSP, but I can't find that reflected in their documentation exactly... they just say you should avoid it: https://playwright.dev/docs/input#type-characters
| @@ -145,23 +173,36 @@ test('shrinks and expands a graph height', async ({ page, utils }) => { | |||
| test('shrinks and expands both width and height', async ({ page, utils }) => { | |||
There was a problem hiding this comment.
We do a bunch of shrink and expand tests but I'd like to see you add a grid layout and prove we can put 4 in a grid pattern.
There was a problem hiding this comment.
Yeah, that's on my to-do list. I'll add new tests and improve coverage in a later PR once parallelization is working
ryan-pratt
changed the title
|
The bucket explorer test is failing consistently, so I'm going to hold off on merging until I figure that out. I think the app is running too slowly to generate enough logs, so the test probably needs to wait longer |
|
|
Note: python unit tests fixed in #1898 |
Went through all the tests, fixed some reliability issues and things the LSP was mad about, and made sure each individual test is runnable on its own in preparation for parallelization