Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix write_conversion of default string to int and don't range check strings #1845

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

jmthomas
Copy link
Member

closes #1825

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (8990750) to head (3f69056).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1845   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files         519      519           
  Lines       40763    40760    -3     
=======================================
- Hits        32434    32432    -2     
+ Misses       8329     8328    -1     
Flag Coverage Δ
python 84.26% <ø> (+<0.01%) ⬆️
ruby-api 48.61% <ø> (ø)
ruby-backend 82.57% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas merged commit 1467fc9 into main Jan 28, 2025
27 of 28 checks passed
@jmthomas jmthomas deleted the convert_string branch January 28, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integer Command Parameter with Write Conversion that takes a String Input
2 participants