Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ScriptRunner open_file_dialog #1814

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Fix ScriptRunner open_file_dialog #1814

merged 2 commits into from
Jan 8, 2025

Conversation

ryan-pratt
Copy link
Contributor

@ryan-pratt ryan-pratt commented Jan 7, 2025

I'm not 100% sure how this worked before... Maybe Vue 2 had some weird behavior with undefined v-models or something? This v-form was also missing any validation rules anyway

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.58%. Comparing base (88de888) to head (75eacc8).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
+ Coverage   79.54%   79.58%   +0.03%     
==========================================
  Files         517      517              
  Lines       40737    40737              
==========================================
+ Hits        32404    32419      +15     
+ Misses       8333     8318      -15     
Flag Coverage Δ
python 84.30% <ø> (+0.10%) ⬆️
ruby-api 48.64% <ø> (ø)
ruby-backend 82.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryan-pratt ryan-pratt requested a review from jmthomas January 8, 2025 01:08
@ryan-pratt ryan-pratt marked this pull request as ready for review January 8, 2025 01:08
Copy link

sonarqubecloud bot commented Jan 8, 2025

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what we get for skipping a playwright test. :-)

Can you take a look at the failing api playwright test ... doesn't look related but we shouldn't have failures.

@ryan-pratt
Copy link
Contributor Author

Can you take a look at the failing api playwright test ... doesn't look related but we shouldn't have failures.

Looks like just a flaky test - I re-ran them and they passed. I'll note this down as a to-do for my playwright test improvement project.

@ryan-pratt ryan-pratt merged commit e5a8384 into main Jan 8, 2025
27 of 28 checks passed
@ryan-pratt ryan-pratt deleted the bug/open-file-dialog branch January 8, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants