Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 404 page for non-existent routes #1789

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Show 404 page for non-existent routes #1789

merged 2 commits into from
Dec 20, 2024

Conversation

ryan-pratt
Copy link
Contributor

closes #1775

@ryan-pratt ryan-pratt requested a review from jmthomas December 19, 2024 22:45
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.59%. Comparing base (620b543) to head (e47db67).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1789      +/-   ##
==========================================
+ Coverage   79.56%   79.59%   +0.02%     
==========================================
  Files         517      517              
  Lines       40737    40737              
==========================================
+ Hits        32414    32423       +9     
+ Misses       8323     8314       -9     
Flag Coverage Δ
python 84.32% <ø> (+0.06%) ⬆️
ruby-api 48.64% <ø> (ø)
ruby-backend 82.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas
Copy link
Member

Going to bad urls like http://localhost:2900/tools/jason now results in:
Screenshot 2024-12-20 at 9 52 33 AM

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@ryan-pratt ryan-pratt merged commit d765f62 into main Dec 20, 2024
27 of 28 checks passed
@ryan-pratt ryan-pratt deleted the notfound-path branch December 20, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle non-existent urls
2 participants