Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uuid to activities #1522

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Add uuid to activities #1522

merged 7 commits into from
Sep 25, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Sep 7, 2024

No description provided.

@jmthomas jmthomas requested a review from ryanmelt September 7, 2024 21:26
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 94.25287% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.99%. Comparing base (b0383ab) to head (a6ac047).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/models/activity_model.rb 94.73% 3 Missing ⚠️
.../openc3/migrations/20240915000000_activity_uuid.rb 94.44% 1 Missing ⚠️
openc3/lib/openc3/script/calendar.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1522      +/-   ##
==========================================
- Coverage   77.04%   76.99%   -0.05%     
==========================================
  Files         611      613       +2     
  Lines       46026    46046      +20     
  Branches      802      802              
==========================================
- Hits        35462    35455       -7     
- Misses      10476    10503      +27     
  Partials       88       88              
Flag Coverage Δ
frontend 55.70% <ø> (-0.18%) ⬇️
python 84.48% <ø> (-0.17%) ⬇️
ruby-api 49.01% <100.00%> (+0.03%) ⬆️
ruby-backend 82.82% <93.58%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make using the new uuid optional. If not there, then do the old behavior of deleting all items at the time.

@ryanmelt
Copy link
Member

Fix API tests and specs

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests

Copy link

@jmthomas jmthomas merged commit ebc6cbf into main Sep 25, 2024
26 of 27 checks passed
@jmthomas jmthomas deleted the activity branch September 25, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants