Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy new scopes #1280

Merged
merged 2 commits into from
May 22, 2024
Merged

Deploy new scopes #1280

merged 2 commits into from
May 22, 2024

Conversation

jmthomas
Copy link
Member

closes #1276

@jmthomas jmthomas requested a review from ryanmelt May 17, 2024 16:06
OpenC3::Logger.info("#{@model_class.name} updated: #{params[:json]}", scope: params[:scope], user: username())
else
model.create
model.deploy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy has two required arguments. You can pass "." and {} for these like in openc3cli.
model.deploy(".", {})

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.42%. Comparing base (1caf8c9) to head (e2cbdbf).
Report is 7 commits behind head on main.

Current head e2cbdbf differs from pull request most recent head 68f12cf

Please upload reports for the commit 68f12cf to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1280   +/-   ##
=======================================
  Coverage   52.42%   52.42%           
=======================================
  Files         197      197           
  Lines        9452     9469   +17     
  Branches      759      760    +1     
=======================================
+ Hits         4955     4964    +9     
- Misses       4414     4420    +6     
- Partials       83       85    +2     
Flag Coverage Δ
frontend 55.15% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
12.5% Duplication on New Code

See analysis details on SonarCloud

@jmthomas jmthomas merged commit 0ace3c2 into main May 22, 2024
18 checks passed
@jmthomas jmthomas deleted the scopes branch May 22, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text logs on some scopes don't get saved
2 participants