Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microservice control #1091

Merged
merged 7 commits into from
Feb 23, 2025
Merged

Microservice control #1091

merged 7 commits into from
Feb 23, 2025

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Feb 10, 2024

Still needs a lot of work ... not sure how to connect the dots.
closes #323

@jmthomas jmthomas requested a review from ryanmelt February 10, 2024 06:39
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 65 lines in your changes missing coverage. Please review.

Project coverage is 76.72%. Comparing base (b0aaee5) to head (567ce88).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...enc3/lib/openc3/operators/microservice_operator.rb 5.88% 48 Missing ⚠️
...lm-api/app/controllers/microservices_controller.rb 11.76% 15 Missing ⚠️
openc3/lib/openc3/models/microservice_model.rb 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   79.60%   76.72%   -2.88%     
==========================================
  Files         525      628     +103     
  Lines       41158    46637    +5479     
  Branches        0      756     +756     
==========================================
+ Hits        32762    35783    +3021     
- Misses       8396    10771    +2375     
- Partials        0       83      +83     
Flag Coverage Δ
python 84.22% <ø> (+<0.01%) ⬆️
ruby-api 48.39% <21.05%> (-0.12%) ⬇️
ruby-backend 82.59% <10.71%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt ryanmelt self-assigned this Feb 10, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ryanmelt ryanmelt requested a review from ryan-pratt February 17, 2025 21:23
@ryanmelt
Copy link
Member

@jmthomas This is complete. Now probably needs a Playwright test.

@ryanmelt ryanmelt assigned jmthomas and unassigned ryanmelt Feb 17, 2025
@jmthomas
Copy link
Member Author

This didn't add the ability to enable debug logging so we'll need another PR for that.

@ryanmelt ryanmelt merged commit 41264af into main Feb 23, 2025
30 checks passed
@ryanmelt ryanmelt deleted the microservice_control branch February 23, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microservice control
2 participants