Add additional save protections to ScriptRunner

[ryanmelt]

No description provided.

[codecov]

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (586127d) 75.20% compared to head (fb5cba1) 75.21%.

Files	Patch %	Lines
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue	69.86%	19 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
+ Coverage   75.20%   75.21%   +0.01%     
==========================================
  Files         592      592              
  Lines       43422    43436      +14     
  Branches      751      754       +3     
==========================================
+ Hits        32654    32671      +17     
+ Misses      10688    10685       -3     
  Partials       80       80              

Flag	Coverage Δ
frontend	55.58% <69.86%> (+0.20%)	⬆️
python	83.53% <ø> (-0.02%)	⬇️
ruby-api	48.76% <ø> (ø)
ruby-backend	80.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmthomas]

I think changing to await on the loads goes a long way to fixing the problem. The saveAllowed variable is now yet another way to determine whether we can save along with this.scriptId and this.editor.getReadOnly() === true. Can this be consolidated down to a single thing we check?

[sonarqubecloud]

Quality Gate failed

Failed conditions

12.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud