Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear SR file cache when stopped #1069

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Clear SR file cache when stopped #1069

merged 1 commit into from
Jan 24, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Jan 24, 2024

Definitely a bug when you run a script and then try to click the drop down and choose another file. This causes the editor to detect a change and the filename gets changed to the original with a *. At that point if you run or click save you will overwrite. But the process is pretty manual in that you have to select a file from that drop down.

I kind of liked the ability to see the files that we drilled into during the test but I couldn't figure out a way to disable the change callback during this change.

@jmthomas jmthomas requested a review from ryanmelt January 24, 2024 00:09
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd31e48) 75.31% compared to head (e99a3b8) 75.31%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   75.31%   75.31%           
=======================================
  Files         592      592           
  Lines       43313    43314    +1     
  Branches      751      751           
=======================================
+ Hits        32620    32621    +1     
+ Misses      10614    10613    -1     
- Partials       79       80    +1     
Flag Coverage Δ
frontend 55.28% <100.00%> (+<0.01%) ⬆️
python 83.63% <100.00%> (ø)
ruby-api 48.76% <ø> (ø)
ruby-backend 80.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt ryanmelt merged commit 3db6407 into main Jan 24, 2024
24 checks passed
@ryanmelt ryanmelt deleted the script_file_cache branch January 24, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants