Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Extractor handle null #1063

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Data Extractor handle null #1063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ugins/packages/openc3-cosmos-tool-dataextractor/src/tools/DataExtractor/DataExtractor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,9 @@ export default {
let columnIndex = columnMap[key]
// Get the value and put it into the correct column
if (typeof packet[key] === 'object') {
if (Array.isArray(packet[key])) {
if (packet[key] === null) {
row[columnIndex] = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea how we'd be getting null in here? I agree it's good to explicitly handle it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens if you playback over items that don't exist in earlier versions of a packet.

} else if (Array.isArray(packet[key])) {
row[columnIndex] = '"[' + packet[key] + ']"'
} else {
let rawVal = packet[key]['raw']
Expand Down
Loading