Data Extractor handle null #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 75.34% 75.31% -0.03%
==========================================
Files 590 590
Lines 43158 43160 +2
Branches 749 750 +1
==========================================
- Hits 32517 32508 -9
- Misses 10563 10573 +10
- Partials 78 79 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmthomas
approved these changes
Jan 18, 2024
| @@ -932,7 +932,9 @@ export default { | |||
| let columnIndex = columnMap[key] | |||
| // Get the value and put it into the correct column | |||
| if (typeof packet[key] === 'object') { | |||
| if (Array.isArray(packet[key])) { | |||
| if (packet[key] === null) { | |||
| row[columnIndex] = '' | |||
There was a problem hiding this comment.
Any idea how we'd be getting null in here? I agree it's good to explicitly handle it.
There was a problem hiding this comment.
It happens if you playback over items that don't exist in earlier versions of a packet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.