Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow python upload/download in TableManager #1052

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Allow python upload/download in TableManager #1052

merged 2 commits into from
Jan 17, 2024

Conversation

jmthomas
Copy link
Member

closes #995

@jmthomas jmthomas requested a review from ryanmelt January 14, 2024 05:08
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (c7574b0) 75.33% compared to head (93e91cd) 75.32%.

Files Patch % Lines
...blemanager/src/tools/TableManager/TableManager.vue 44.44% 10 Missing ⚠️
openc3/python/openc3/script/storage.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
- Coverage   75.33%   75.32%   -0.02%     
==========================================
  Files         590      590              
  Lines       43150    43158       +8     
  Branches      749      749              
==========================================
- Hits        32508    32507       -1     
- Misses      10563    10573      +10     
+ Partials       79       78       -1     
Flag Coverage Δ
python 83.55% <0.00%> (-0.07%) ⬇️
ruby-api 48.71% <ø> (ø)
ruby-backend 80.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jmthomas jmthomas merged commit 1cfef06 into main Jan 17, 2024
23 of 24 checks passed
@jmthomas jmthomas deleted the table_manager branch January 17, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow TableManager to use Python for upload / download
2 participants