Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to no tlm cache #1037

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Default to no tlm cache #1037

merged 1 commit into from
Jan 10, 2024

Conversation

ryanmelt
Copy link
Member

closes #1036

@ryanmelt ryanmelt requested a review from jmthomas January 10, 2024 01:32
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e98de98) 75.33% compared to head (07d8fc4) 75.33%.

Files Patch % Lines
openc3/lib/openc3/models/cvt_model.rb 57.14% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   75.33%   75.33%           
=======================================
  Files         590      590           
  Lines       43123    43125    +2     
  Branches      749      749           
=======================================
+ Hits        32486    32488    +2     
  Misses      10559    10559           
  Partials       78       78           
Flag Coverage Δ
frontend 55.15% <ø> (-0.02%) ⬇️
python 83.66% <ø> (+0.03%) ⬆️
ruby-api 48.69% <ø> (ø)
ruby-backend 80.43% <76.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt ryanmelt merged commit cbecce9 into main Jan 10, 2024
24 checks passed
@ryanmelt ryanmelt deleted the default_to_no_cache branch January 10, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default to no caching in apis
2 participants