New cmd keywords for related telemetry and remove legacy snmp #1005
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
- Coverage 75.37% 75.29% -0.09%
==========================================
Files 588 588
Lines 42879 42968 +89
Branches 747 747
==========================================
+ Hits 32320 32351 +31
- Misses 10481 10539 +58
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
| COMMAND <%= target_name %> SETPARAMS BIG_ENDIAN "Sets numbered parameters" | ||
| <%= render "_ccsds_cmd.txt", locals: {id: 4} %> | ||
| # ERB syntax: | ||
| <% (1..5).each do |i| %> | ||
| APPEND_PARAMETER VALUE<%= i %> 16 UINT 0 5 1 "Value <%= i %> setting" | ||
| RELATED_ITEM <%= target_name %> PARAMS VALUE<%= i %> | ||
| <% end %> |
There was a problem hiding this comment.
Remove RELATED_ITEM and add SCREEN INST PARAMS just to show how that works
There was a problem hiding this comment.
I'll add both. SCREEN wins if present.
| @@ -214,7 +214,8 @@ def process_file(filename, process_target_name) | |||
| 'PARAMETER', 'ID_ITEM', 'ID_PARAMETER', 'ARRAY_ITEM', 'ARRAY_PARAMETER', 'APPEND_ITEM',\ | |||
| 'APPEND_PARAMETER', 'APPEND_ID_ITEM', 'APPEND_ID_PARAMETER', 'APPEND_ARRAY_ITEM',\ | |||
| 'APPEND_ARRAY_PARAMETER', 'ALLOW_SHORT', 'HAZARDOUS', 'PROCESSOR', 'META',\ | |||
| 'DISABLE_MESSAGES', 'HIDDEN', 'DISABLED', 'ACCESSOR', 'TEMPLATE', 'TEMPLATE_FILE' | |||
| 'DISABLE_MESSAGES', 'HIDDEN', 'DISABLED', 'ACCESSOR', 'TEMPLATE', 'TEMPLATE_FILE',\ | |||
| 'RESPONSE', 'ERROR_RESPONSE', 'SCREEN', 'RELATED_ITEM' | |||
There was a problem hiding this comment.
You need to document all these keywords!
| when 'ERROR_RESPONSE' | ||
| usage = "#{keyword} <Target Name> <Packet Name>" | ||
| parser.verify_num_parameters(2, 2, usage) | ||
| @current_packet.error_response = [params[0].upcase, params[1].upcase] |
There was a problem hiding this comment.
How will RESPONSE and ERROR_RESPONSE be used?
There was a problem hiding this comment.
This will be the standard way to build command/response patterns. I'm using it with SNMP
|
closes #403