From a682dd91a6e5502bf47186cda1680fb86a0d5d5f Mon Sep 17 00:00:00 2001 From: Ryan Pratt Date: Tue, 7 Jan 2025 12:40:12 -0700 Subject: [PATCH 1/2] Fix ScriptRunner open_file_dialog --- .../src/tools/ScriptRunner/Dialogs/FileDialog.vue | 3 +++ 1 file changed, 3 insertions(+) diff --git a/openc3-cosmos-init/plugins/packages/openc3-cosmos-tool-scriptrunner/src/tools/ScriptRunner/Dialogs/FileDialog.vue b/openc3-cosmos-init/plugins/packages/openc3-cosmos-tool-scriptrunner/src/tools/ScriptRunner/Dialogs/FileDialog.vue index adec6d0855..ee144f73ac 100644 --- a/openc3-cosmos-init/plugins/packages/openc3-cosmos-tool-scriptrunner/src/tools/ScriptRunner/Dialogs/FileDialog.vue +++ b/openc3-cosmos-init/plugins/packages/openc3-cosmos-tool-scriptrunner/src/tools/ScriptRunner/Dialogs/FileDialog.vue @@ -45,6 +45,7 @@ !!value?.length || 'Required'], } }, computed: { From 75eacc8b80df6fe4eff1e728894d222055d9cfce Mon Sep 17 00:00:00 2001 From: Ryan Pratt Date: Tue, 7 Jan 2025 18:08:23 -0700 Subject: [PATCH 2/2] Fix open_file_dialog playwright test --- playwright/tests/script-runner/prompts.spec.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/playwright/tests/script-runner/prompts.spec.ts b/playwright/tests/script-runner/prompts.spec.ts index 4a571c6204..cf79b533f1 100644 --- a/playwright/tests/script-runner/prompts.spec.ts +++ b/playwright/tests/script-runner/prompts.spec.ts @@ -291,8 +291,7 @@ test('opens a dialog for prompt', async ({ page, utils }) => { await expect(page.locator('[data-test=state] input')).toHaveValue('stopped') }) -// Opening a file dialog might not be possible in a Github action? -test.skip('opens a file dialog', async ({ page, utils }) => { +test('opens a file dialog', async ({ page, utils }) => { await page.locator('textarea').fill(` file = open_file_dialog("Open a single file", "Choose something interesting") puts file.read @@ -320,15 +319,15 @@ test.skip('opens a file dialog', async ({ page, utils }) => { // It is important to call waitForEvent before click to set up waiting. page.waitForEvent('filechooser'), // Open the file chooser - page.locator('text=Choose File').click(), + page.getByLabel('Choose File').first().click(), ]) - await fileChooser.setFiles('.env') + await fileChooser.setFiles('package.json') await page.locator('.v-dialog >> button:has-text("Ok")').click() await expect(page.locator('[data-test=state] input')).toHaveValue('stopped') await expect(page.locator('[data-test=output-messages]')).toContainText( - 'File(s): [".env"]', + 'File(s): ["package.json"]', ) await expect(page.locator('[data-test=output-messages]')).toContainText( - 'RUBYGEMS_URL', + 'devDependencies', ) })