Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments to be added in inject results screen #2225

Open
damians-filigran opened this issue Jan 16, 2025 · 0 comments
Open

Allow comments to be added in inject results screen #2225

damians-filigran opened this issue Jan 16, 2025 · 0 comments
Labels
feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team

Comments

@damians-filigran
Copy link

Context

This relates to adding comments to injects based on manual observations as a simulation progresses.

Use case

As a red teamer or blue teamer using OBAS interactively, as I am reviewing the results of specific injects in a simulation, I would like to be able to add comments as I am viewing the results and trace outputs on each target endpoint.

At present, there is no field to do so in this screen; there is a comments field in the report itself, but no-where to add comments before the reporting stage.

It would be very useful to have a comments box underneath the expectation results on each inject. This would support the workflow of the read teamer adding their results and observations inline as they perform or analyse the inject, and then be able to review and edit those comments in the final reporting stage.

Current Workaround

Take manual notes elsewhere, and them add them into the comment in the reporting stage.

Proposed Solution

Add a comments field under the results panel in the inject results screen, and carry those comments through to the final simulation reporting screen (into the comments there), where they can be edited further.

Suggested location

Image

Additional Information

If the feature request is approved, would you be willing to submit a PR?

Yes

@damians-filigran damians-filigran added feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team
Projects
None yet
Development

No branches or pull requests

1 participant