Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:command changes #2644

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

anj20
Copy link
Contributor

@anj20 anj20 commented Feb 12, 2025

Purpose of PR?: Replace the mswms_demodata command with a --seed option for the mswms command, aligning it with the behavior of the seed option in mscolab

Fixes #2631

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::
Verified that the seed function runs correctly when executed using mswms -seed

Checklist:

  • Bug fix. Fixes #
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

@@ -44,6 +44,8 @@ def main():
parser.add_argument("--debug", help="show debugging log messages on console", action="store_true", default=False)
parser.add_argument("--logfile", help="If set to a name log output goes to that file", dest="logfile",
default=None)
parser.add_argument("-s", "--seed", help="creates demodata for the mswms server",
action="store_true", default=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and what does this?

Have you tried the examples?

@ReimarBauer
Copy link
Member

@anj20 do you have time to finish this in the next days?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change the command mswms_demodata to seed of mswms
2 participants