Add Fullname Support to User Profiles #2608

annapurna-gupta · 2025-01-25T08:13:14Z

Fixes #1282

mslib/mscolab/file_manager.py

mslib/mscolab/migrations/versions/922e4d9c94e2_to_version_10_0_0.py

mslib/msui/qt5/ui_add_user_dialog.py

ReimarBauer · 2025-01-26T11:29:42Z

try to alter a test that now also the fullname is checked if one was added

annapurna-gupta · 2025-01-26T11:32:19Z

try to alter a test that now also the fullname is checked if one was added

i am sorry, i didn't understand...can you please explain

ReimarBauer · 2025-01-26T11:38:15Z

Where we currenly have Change Avatar, there should be an "Edit"
The Edit should be used to change the Avatar and the Full Name. Changing the e-mail is currently not allowed by user action.

annapurna-gupta · 2025-01-26T11:55:44Z

Where we currenly have Change Avatar, there should be an "Edit" The Edit should be used to change the Avatar and the Full Name. Changing the e-mail is currently not allowed by user action.

Whenever I try to add a user, an error is displayed.

annapurna-gupta · 2025-01-26T11:56:43Z

Where we currenly have Change Avatar, there should be an "Edit" The Edit should be used to change the Avatar and the Full Name. Changing the e-mail is currently not allowed by user action.

Is it possible to create a new issue for this change? I would be happy to work on it.

ReimarBauer · 2025-01-26T12:18:55Z

Where we currenly have Change Avatar, there should be an "Edit" The Edit should be used to change the Avatar and the Full Name. Changing the e-mail is currently not allowed by user action.

Is it possible to create a new issue for this change? I would be happy to work on it.
yes, after the half feature is added, currently someone will ask where is the fullname...

ReimarBauer · 2025-01-26T12:24:43Z

try to alter a test that now also the fullname is checked if one was added

i am sorry, i didn't understand...can you please explain

We have now changed the API and the model. The CI runs should cover the changes. The tests are all in your fork too
https://github.com/annapurna-gupta/MSS/tree/feature/add-fullname-nickname/tests

We should have at least a test which covers adding a fullname on user creation
e.g. https://github.com/annapurna-gupta/MSS/blob/feature/add-fullname-nickname/tests/_test_msui/test_mscolab.py#L178

mslib/mscolab/server.py

ReimarBauer · 2025-01-31T09:19:53Z

@annapurna-gupta Eric has a good documentation about pytest https://pytest-with-eric.com/
There some more sources on the net https://realpython.com/pytest-python-testing/
on pyvideo you do find many https://pyvideo.org/tag/pytest/

annapurna-gupta · 2025-01-31T15:21:28Z

@annapurna-gupta Eric has a good documentation about pytest https://pytest-with-eric.com/
There some more sources on the net https://realpython.com/pytest-python-testing/
on pyvideo you do find many https://pyvideo.org/tag/pytest/

Thanks for the pytest resources! I couldn’t work on the issue as my college practicals were going on.

annapurna-gupta · 2025-02-03T18:37:11Z

Hi @ReimarBauer , I’ve pushed PR, please review it...meanwhile, I’ll fix the tests.

tests/_test_mscolab/test_seed.py

ReimarBauer

have a look on the signature of add_user and improve it and add tests which use fullname

export QT_QPA_PLATFORM=offscreen
pytest -k test_url_combo
ERROR tests/_test_msui/test_mscolab.py::Test_Mscolab_connect_window::test_url_combo - TypeError: add_user() missing 1 required positional argument: 'fullname'

annapurna-gupta · 2025-02-06T11:38:48Z

@ReimarBauer can you please review the changes.

mslib/mscolab/migrations/versions/89cbaa26ae78_to_version_10_0_0.py

mslib/mscolab/server.py

mslib/msui/qt5/ui_add_user_dialog.py

ReimarBauer

see comments and also look into the tests output of the CI

annapurna-gupta · 2025-02-07T14:48:17Z

see comments and also look into the tests output of the CI

Could you please guide me on how to fix the migration script issue? Once that is resolved, I will fix the CI results.

ReimarBauer · 2025-02-07T20:06:46Z

Look into the content of the added file. We we will have only 1 version 10.0.0 release.
So we want only 1 migration file.

Your new file is not needed.

Move the changes to the existing mig script for version 10.0.0.

annapurna-gupta · 2025-02-08T07:10:50Z

Look into the content of the added file. We we will have only 1 version 10.0.0 release. So we want only 1 migration file.

Your new file is not needed.

Move the changes to the existing mig script for version 10.0.0.

okk

annapurna-gupta · 2025-02-08T15:57:31Z

@ReimarBauer could you please look at the changes and the workflow error.

annapurna-gupta · 2025-02-13T11:09:37Z

@ReimarBauer could you please take a look in this pr.

ReimarBauer

see comments

tests/_test_msui/test_mscolab.py

mslib/mscolab/server.py

mslib/mscolab/migrations/versions/922e4d9c94e2_to_version_10_0_0.py

ReimarBauer · 2025-02-19T16:40:15Z

mslib/mscolab/server.py

+    processed_parts = []
+    for part in parts:
+        if "-" in part:
+            processed_part = part.lower()


why lowercase?

so that it could not break "Jean--Luc" this kind of input further and process it as whole.

mslib/mscolab/server.py

tests/_test_msui/test_mscolab.py

ReimarBauer

Please add a test for the new function test_process_name

mslib/mscolab/migrations/versions/922e4d9c94e2_to_version_10_0_0.py

mslib/mscolab/server.py

annapurna-gupta · 2025-02-20T14:34:03Z

Hii @ReimarBauer, half of the test are still falling.

ReimarBauer · 2025-02-20T14:38:02Z

Hii @ReimarBauer, half of the test are still falling.

Hi

Debug this one first

https://github.com/Open-MSS/MSS/actions/runs/13435389961/job/37536411745#step:9:1819

FAILED tests/_test_mscolab/test_server.py::Test_Server::test_check_login - assert False is True

Those are failing because of timeout you can ignore for now.
Those related to your change, need changes or your Implantation does.

annapurna-gupta · 2025-02-20T15:47:37Z

Hii @ReimarBauer, half of the test are still falling.

Hi

Debug this one first

https://github.com/Open-MSS/MSS/actions/runs/13435389961/job/37536411745#step:9:1819

FAILED tests/_test_mscolab/test_server.py::Test_Server::test_check_login - assert False is True

okk

ReimarBauer · 2025-02-21T12:29:15Z

mslib/mscolab/server.py

@@ -248,7 +249,16 @@ def check_login(emailid, password):
    return False


-def register_user(email, password, username):
+def process_fullname(fullname):
+    fullname = " ".join(fullname.split())


the reason for this is to have only 1 blank used in a name?
maybe add a comment if so.

yes, the reason of this is to handle multiple spaces between fullname, i will add commant.

mslib/mscolab/server.py

ReimarBauer · 2025-02-21T12:40:04Z

tests/_test_mscolab/test_server_auth_required.py

@@ -60,10 +60,6 @@ def test_verify_pw(self):
        assert verify_pw("unknown", "unknown") is False
        assert verify_pw("user", "wrong") is False

-    def test_register_user(self):


why was this removed?

sorry, i was trying to fix an error that is why i removed it.. i will put it back.

ReimarBauer

see my question about the removed test.

annapurna-gupta · 2025-02-21T15:16:11Z

Hi @ReimarBauer, i have made the requested changes.

ReimarBauer · 2025-02-21T16:10:57Z

Thx I look later today.

annapurna-gupta · 2025-02-21T16:29:26Z

Thx I look later today.

btw what is your time zone.

ReimarBauer

Thx

ReimarBauer · 2025-02-22T17:53:24Z

@matrss please do a final review :)

ReimarBauer · 2025-02-22T17:53:53Z

Thx I look later today.

btw what is your time zone.

MEZ

ReimarBauer reviewed Jan 26, 2025

View reviewed changes

mslib/mscolab/file_manager.py Outdated Show resolved Hide resolved

ReimarBauer reviewed Jan 26, 2025

View reviewed changes

mslib/mscolab/migrations/versions/922e4d9c94e2_to_version_10_0_0.py Outdated Show resolved Hide resolved

ReimarBauer reviewed Jan 26, 2025

View reviewed changes

mslib/msui/qt5/ui_add_user_dialog.py Show resolved Hide resolved

ReimarBauer reviewed Jan 26, 2025

View reviewed changes

mslib/mscolab/server.py Outdated Show resolved Hide resolved

ReimarBauer reviewed Feb 4, 2025

View reviewed changes

tests/_test_mscolab/test_seed.py Show resolved Hide resolved

ReimarBauer requested changes Feb 4, 2025

View reviewed changes