updated process_fullname and it's test function

mslib/mscolab/migrations/versions/922e4d9c94e2_to_version_10_0_0.py

@@ -31,7 +31,7 @@ def upgrade():
 
 
 def downgrade():
-# ### commands auto generated by Alembic - please adjust! ###
+    # ### commands auto generated by Alembic - please adjust! ###
     with op.batch_alter_table('users', schema=None) as batch_op:
         batch_op.drop_column('profile_image_path')
         batch_op.drop_column('fullname')

mslib/mscolab/server.py

@@ -251,30 +251,11 @@ def check_login(emailid, password):
 
 def process_fullname(fullname):
     fullname = " ".join(fullname.split())
-    if not fullname:
-        return {"success": True, "processed_name": ""}
-
     result_with_regex = slugify(fullname, regex_pattern=r"[^a-zA-Z\s\-]")
-    if fullname.lower() != result_with_regex:
-        return {"success": False, "message": "Invalid characters detected in fullname."}
-
-    parts = fullname.split()
-
-    processed_parts = []
-    for part in parts:
-        if "-" in part:
-            processed_part = part.lower()
-            if not processed_part:
-                return {"success": False, "message": "Fullname contains invalid part after processing."}
-            processed_parts.append(processed_part)
-        else:
-            processed_part = slugify(part)
-            if not processed_part:
-                return {"success": False, "message": "Fullname contains invalid part after processing."}
-            processed_parts.append(processed_part)
-
-    final_name = " ".join(processed_parts)
-    return {"success": True, "processed_name": final_name}
+    if fullname.lower() == result_with_regex:
+        return {"success": True, "processed_name": fullname}
+    else:
+        return {"success": False, "message": "Invalid chars detected"}
 
 
 def register_user(email, password, username, fullname):

tests/_test_mscolab/test_server.py

@@ -87,41 +87,24 @@ def test_register_user(self):
             assert result["success"] is True
 
     def test_process_fullname(self):
-        result = process_fullname("Jean-Luc Picard")
-        assert result["success"] is True
-        assert result["processed_name"] == "jean-luc picard"
-
         result = process_fullname("John Doe")
         assert result["success"] is True
-        assert result["processed_name"] == "john doe"
-
-        result = process_fullname("Anu")
-        assert result["success"] is True
-        assert result["processed_name"] == "anu"
-
+        assert result["processed_name"] == "John Doe"
         result = process_fullname("")
         assert result["success"] is True
         assert result["processed_name"] == ""
-
-        result = process_fullname("@@@###")
-        assert result["success"] is False
-        assert result["message"] == "Invalid characters detected in fullname."
-
-        result = process_fullname(" John   Doe")
-        assert result["success"] is True
-        assert result["processed_name"] == "john doe"
-
-        result = process_fullname("Jean--Luc Picard")
-        assert result["success"] is True
-        assert result["processed_name"] == "jean--luc picard"
-
-        result = process_fullname("John Smith-Doe")
-        assert result["success"] is True
-        assert result["processed_name"] == "john smith-doe"
-
         result = process_fullname("John123")
         assert result["success"] is False
-        assert result["message"] == "Invalid characters detected in fullname."
+        assert result["message"] == "Invalid chars detected"
+        result = process_fullname("John_Doe")
+        assert result["success"] is False
+        assert result["message"] == "Invalid chars detected"
+        result = process_fullname("@#")
+        assert result["success"] is False
+        assert result["message"] == "Invalid chars detected"
+        result = process_fullname("Anne-Marie")
+        assert result["success"] is True
+        assert result["processed_name"] == "Anne-Marie"
 
     def test_check_login(self):
         with self.app.test_client():