Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#279) Рефакторинг метода to-regex класса FiniteAutomaton #282

Merged
merged 21 commits into from
Nov 25, 2023
Merged

(#279) Рефакторинг метода to-regex класса FiniteAutomaton #282

merged 21 commits into from
Nov 25, 2023

Conversation

AngelicHedgehog
Copy link
Collaborator

@AngelicHedgehog AngelicHedgehog commented Oct 23, 2023 •
edited by mathhyyn
Loading

(#279) Рефакторинг метода to-regex класса FiniteAutomaton
close #173

@AngelicHedgehog AngelicHedgehog added the refactor надо улучшить качество кода label Oct 23, 2023
@AngelicHedgehog AngelicHedgehog linked an issue Oct 23, 2023 that may be closed by this pull request
Рефакторинг FiniteAutomaton::to_regex #279
Closed
@mathhyyn
Copy link
Collaborator

mathhyyn commented Oct 23, 2023 •
edited
Loading 

R = {(b(a|b))*}
N = Arden.Glushkov R
Equiv N R

image
все еще грустно :(

@AngelicHedgehog
Copy link
Collaborator Author

Ла-дно, думал код верно выполняет свою задачу, но раз так, буду переписывать алгоритм

Base automatically changed from fa-regex-refactoring to main November 4, 2023 21:24
@xendalm xendalm marked this pull request as draft November 12, 2023 21:11
@AngelicHedgehog AngelicHedgehog marked this pull request as ready for review November 22, 2023 19:29
xendalm
xendalm requested changes Nov 23, 2023
View reviewed changes
xendalm
xendalm requested changes Nov 23, 2023
View reviewed changes
@AngelicHedgehog AngelicHedgehog removed their assignment Nov 23, 2023
xendalm
xendalm requested changes Nov 24, 2023
View reviewed changes
@mathhyyn
(#302) тест на генерируемых регулярках
d4d0207 
все проходит 👍
(думаю, лишние скобки, возникающие из-за повсеместных конкатенций с eps, мы переживем)
@xendalm xendalm merged commit 5818e3f into main Nov 25, 2023
This was linked to issues Nov 25, 2023
Arden bug's #173
Closed
Обновление и расширение модуля тестов test_arden #302
Open
@AngelicHedgehog AngelicHedgehog deleted the vilenskii/refacts branch November 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xendalm xendalm xendalm approved these changes

@mathhyyn mathhyyn Awaiting requested review from mathhyyn

Assignees

@xendalm xendalm

@mathhyyn mathhyyn

Labels
refactor надо улучшить качество кода
Projects
Чиполлино
Status: ✅ Завершена
Milestone
No milestone
3 participants
@AngelicHedgehog @mathhyyn @xendalm