Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Рефакторинг FiniteAutomaton::to_regex #279

Closed
AngelicHedgehog opened this issue Oct 23, 2023 · 1 comment · Fixed by #282
Closed

Рефакторинг FiniteAutomaton::to_regex #279

AngelicHedgehog opened this issue Oct 23, 2023 · 1 comment · Fixed by #282
Assignees
@AngelicHedgehog
Labels
refactor надо улучшить качество кода

Comments

@AngelicHedgehog
Copy link
Collaborator

AngelicHedgehog commented Oct 23, 2023 •
edited
Loading

Требуется провести рефакторинг кода метода to_regex класса FiniteAutomaton.

Задание выдано в рамках программы искусственного улучшения успеваемости по ТФЯ
@AngelicHedgehog AngelicHedgehog self-assigned this Oct 23, 2023
@xendalm
Copy link
Collaborator

xendalm commented Oct 23, 2023

Рекомендую отпочковаться от этой ветки, чтобы потом мы не решали конфликты https://github.com/OnionGrief/Chipollino/tree/fa-regex-refactoring

@AngelicHedgehog AngelicHedgehog added the refactor надо улучшить качество кода label Oct 23, 2023
AngelicHedgehog added a commit that referenced this issue Oct 23, 2023
@AngelicHedgehog
Refactored FiniteAutomaton::to_regex #279
928fe1c
AngelicHedgehog added a commit that referenced this issue Oct 23, 2023
@AngelicHedgehog
Removed artefact #279
0be5062
@AngelicHedgehog AngelicHedgehog moved this to 👀 На ревью in Чиполлино Oct 23, 2023
@AngelicHedgehog AngelicHedgehog moved this from 👀 На ревью to 🏗 В разработке in Чиполлино Oct 23, 2023
This was linked to pull requests Oct 23, 2023
Рефакторинг метода to-regex класса FiniteAutomaton #279 #281
Closed
(#279) Рефакторинг метода to-regex класса FiniteAutomaton #282
Merged
@AngelicHedgehog AngelicHedgehog moved this from 🏗 В разработке to 👀 На ревью in Чиполлино Oct 23, 2023
@AngelicHedgehog AngelicHedgehog moved this from 👀 На ревью to 🏗 В разработке in Чиполлино Oct 23, 2023
AngelicHedgehog added a commit that referenced this issue Nov 22, 2023
@AngelicHedgehog
(#279) удалено старое содержимое метода
58b8a27
AngelicHedgehog added a commit that referenced this issue Nov 22, 2023
@AngelicHedgehog
(#279) Первая реализация FiniteAutomaton::to_regex
f0fe215
AngelicHedgehog added a commit that referenced this issue Nov 22, 2023
@AngelicHedgehog
(#279) Добавлено логирование
7903085
AngelicHedgehog added a commit that referenced this issue Nov 22, 2023
@AngelicHedgehog
(#279) Устранена ошибка ссылки на rvalue
b5ca6d5
AngelicHedgehog added a commit that referenced this issue Nov 22, 2023
@AngelicHedgehog
(#279) Удалены лишние заголовки
e893cb4
AngelicHedgehog added a commit that referenced this issue Nov 22, 2023
@AngelicHedgehog
(#279) Исправлена Segmentation fault
b4d46ae
AngelicHedgehog added a commit that referenced this issue Nov 22, 2023
@AngelicHedgehog
(#279) Фикс бага формата регулярки возврата
ea1e4c3
@AngelicHedgehog AngelicHedgehog mentioned this issue Nov 22, 2023
Merged
@AngelicHedgehog AngelicHedgehog moved this from 🏗 В разработке to 👀 На ревью in Чиполлино Nov 22, 2023
AngelicHedgehog added a commit that referenced this issue Nov 23, 2023
@AngelicHedgehog
(#279) Устранено лишнее преобразование финальной регулярки
3fe5878 
- раньше выдавало ошибку на тестах
AngelicHedgehog added a commit that referenced this issue Nov 23, 2023
@AngelicHedgehog
(#279) Добавлено определение номера начального состояния
13c0de8
AngelicHedgehog added a commit that referenced this issue Nov 23, 2023
@AngelicHedgehog
(#279) Излишние выкладки
ce9370f
AngelicHedgehog added a commit that referenced this issue Nov 23, 2023
@AngelicHedgehog
(#279) Добавлена генерация афловита с языком
e1b2860
AngelicHedgehog added a commit that referenced this issue Nov 23, 2023
@AngelicHedgehog
(#279) Исправлен метод генерации языка финальной регулярки
012327f
AngelicHedgehog added a commit that referenced this issue Nov 23, 2023
@AngelicHedgehog
(#279) Изменён способ задания языка на явный
f9e69c0
xendalm added a commit that referenced this issue Nov 24, 2023
@xendalm
(#279) fixed arden test, added auto alphabet generating (new AlgExpre…
10b6e15 
…ssion constructor)
xendalm added a commit that referenced this issue Nov 24, 2023
@xendalm
(#279) fixed arden test, added auto alphabet generating (new AlgExpre…
4bd2149 
…ssion constructor)
mathhyyn added a commit that referenced this issue Nov 24, 2023
@mathhyyn
(#279) тест на генерируемых регулярках
9edefbc 
все проходит 👍
(думаю, лишние скобки, возникающие из-за повсеместных конкатенций с eps, мы переживем)
@github-project-automation github-project-automation bot moved this from 👀 На ревью to ✅ Завершена in Чиполлино Nov 25, 2023
xendalm added a commit that referenced this issue Nov 25, 2023
@xendalm
Merge pull request #282 from OnionGrief/vilenskii/refacts
5818e3f 
(#279) Рефакторинг метода to-regex класса FiniteAutomaton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AngelicHedgehog AngelicHedgehog

Labels
refactor надо улучшить качество кода
Projects
Чиполлино
Status: ✅ Завершена
Milestone
No milestone
2 participants
@xendalm @AngelicHedgehog