feat!: rename getInstanceId
to getNodeId
and add a scope
option
#211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@affects atoms, stores
Description
With the introduction of scoped atoms came the concept of scoped ids. These
@scope()
-suffixed ids can currently only be generated automatically by Zedux internals.Expose a way to create scoped ids via the existing
getInstanceId
method onAtomTemplateBase
. Pass an optional third object parameter with ascope
map pointing contexts to their contextual values that should be added to the id. Also renamegetInstanceId
togetNodeId
to match the new nomenclature.Breaking Changes
The
AtomTemplateBase
class is the last thing that needs some love for Zedux v2. Rename:getInstanceId
->getNodeId
_createInstance
->_instantiate
_config
->c
(short forconfig
)_value
->v
(short forvalueOrFactory
)