Skip to content

Commit

Permalink
chore: fix TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
0xJem committed Jan 7, 2025
1 parent 76d458c commit 7b718c5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/policies/CDFacility.sol
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ contract CDFacility is Policy, RolesConsumer, IConvertibleDepositFacility, Reent
// Validate that the deposit amount is not greater than the remaining deposit
if (amount_ > position.remainingDeposit) revert CDF_InvalidAmount(positionId_, amount_);

convertedTokenOut = (amount_ * SCALE) / position.conversionPrice; // TODO check SCALE, rounding
convertedTokenOut = (amount_ * SCALE) / position.conversionPrice;

return convertedTokenOut;
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/modules/CDPOS/setDisplayDecimals.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import {Module} from "src/Kernel.sol";

contract SetDisplayDecimalsCDPOSTest is CDPOSTest {
// when the caller is not a permissioned address
// [ ] it reverts
// [ ] it sets the display decimals
// [X] it reverts
// [X] it sets the display decimals

function test_notPermissioned_reverts() public {
// Expect revert
Expand Down

0 comments on commit 7b718c5

Please sign in to comment.