Breaking change fix daylight detection from timezone utc to local timezone needs adjustment in config file #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config.yaml file See config_template.yaml section: photo_general: timezone: "Europe/Berlin" # timezone for daylight detection location: "Berlin" # location for daylight detection This is a breaking change! Config file must be adjusted to this accordingly.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 83.28% 83.34% +0.05%
==========================================
Files 32 32
Lines 1962 1969 +7
==========================================
+ Hits 1634 1641 +7
Misses 328 328 ☔ View full report in Codecov by Sentry. |
OliverDrechsler
deleted the
fix/local_timezone_sunrise_and_sunset_detect_instead_common_utc_time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix daylight detection from timezone utc to local timezone defined in config.yaml file
See config_template.yaml section:
photo_general:
timezone: "Europe/Berlin" # timezone for daylight detection
location: "Berlin" # location for daylight detection
This is a breaking change!
Config file must be adjusted to this accordingly.
Description 📋
Please include a summary of the changes made in this PR and provide any context necessary for the change.
Fixes # (issues)
Type of change 🤔
Please tick any that are relevant to this PR and remove any that aren't.
Submission checklist ✅