Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check older paramter names are updated and working in 2.3.4 #1042

Closed
sambles opened this issue May 16, 2024 · 1 comment · Fixed by #1045
Closed

Check older paramter names are updated and working in 2.3.4 #1042

sambles opened this issue May 16, 2024 · 1 comment · Fixed by #1045
Assignees
@sambles
Labels
bug LTS - 1.28 LTS - 2.3
Milestone
2.4.0

Comments

@sambles
Copy link
Contributor

sambles commented May 16, 2024 •
edited
Loading

Issue Description

Test if using an older parameter in oasislmf.json is correctly swapped for its updated equivalent.

Example:
lookup_package_dir -> lookup_module_path
@sambles sambles self-assigned this May 16, 2024
@sambles sambles moved this to In Progress in Oasis Dev Team Tasks May 16, 2024
@sambles sambles removed the Question label May 16, 2024
@sambles
Copy link
Contributor Author

sambles commented May 16, 2024 •
edited
Loading

Confirmed as bug:

Only seems to be a V1 worker image problem, The V2 workers correctly detect and updates older keys:

id=2, status=INPUTS_GENERATION_STARTED
[2024-05-17 09:10:12,405: WARNING/ForkPoolWorker-16] Deprecated key(s) in MDK config:
[2024-05-17 09:10:12,405: WARNING/ForkPoolWorker-16]  'keys_data_path' loaded as 'lookup_data_dir'
[2024-05-17 09:10:12,405: WARNING/ForkPoolWorker-16]  'source_exposure_file_path' loaded as 'oed_location_csv'

@sambles sambles linked a pull request May 17, 2024 that will close this issue
Fixed missing call to param update method - V1 Workers #1045
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Oasis Dev Team Tasks May 17, 2024
@awsbuild awsbuild modified the milestones: 1.28.8, 2.3.5 May 30, 2024
@awsbuild awsbuild modified the milestones: 2.3.5, 2.4.0 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sambles sambles

Labels
bug LTS - 1.28 LTS - 2.3
Projects
Oasis Dev Team Tasks
Status: Done
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Fixed missing call to param update method - V1 Workers OasisLMF/OasisPlatform
2 participants
@sambles @awsbuild